[webkit-reviews] review denied: [Bug 38169] check-webkit-style returns non-zero when patch is entirely minus lines : [Attachment 63427] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 4 01:31:39 PDT 2010


Shinichiro Hamaji <hamaji at chromium.org> has denied Kenichi Ishibashi
<bashi at google.com>'s request for review:
Bug 38169: check-webkit-style returns non-zero when patch is entirely minus
lines
https://bugs.webkit.org/show_bug.cgi?id=38169

Attachment 63427: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=63427&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
We need to update unittest for them.


WebKitTools/Scripts/webkitpy/style/filereader.py:61
 +	    self.processed_file_count = 0
Please update the docstring above.


More information about the webkit-reviews mailing list