[webkit-reviews] review denied: [Bug 43344] Web Inspector: Extensions API tests fail on Qt & GTK : [Attachment 63367] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 3 21:53:33 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 43344: Web Inspector: Extensions API tests fail on Qt & GTK
https://bugs.webkit.org/show_bug.cgi?id=43344

Attachment 63367: patch
https://bugs.webkit.org/attachment.cgi?id=63367&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/InspectorController.cpp:464
 +	if (m_scriptsToEvaluateOnLoad.size()) {
So we are now hitting this code for every page. I never liked this thing, I
don't think we should extend its capabilities.


More information about the webkit-reviews mailing list