[webkit-reviews] review denied: [Bug 43425] Fix rendering of speech button and enable layout tests : [Attachment 63338] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 3 17:56:55 PDT 2010


Kent Tamura <tkent at chromium.org> has denied Satish Sampath
<satish at chromium.org>'s request for review:
Bug 43425: Fix rendering of speech button and enable layout tests
https://bugs.webkit.org/show_bug.cgi?id=43425

Attachment 63338: Patch
https://bugs.webkit.org/attachment.cgi?id=63338&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>

> There is one known issue for chromium-linux where the spin button doesn't
appear if speech is enabled, I'll work on that in a separate patch.

We shouldn't add expectations which we know it's incorrect. 
test_expectations.txt should have an entry of LINUX numberandspeech.
GTK has no spinbutton implementation yet. I think we shouldn't add expectation
files for GTK numberandspeech and keep it skipped.


More information about the webkit-reviews mailing list