[webkit-reviews] review granted: [Bug 42860] Compositing iframe layout test crashes in WebKit2 : [Attachment 63377] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 42860: Compositing iframe layout test crashes in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42860

Attachment 63377: Patch
https://bugs.webkit.org/attachment.cgi?id=63377&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
> +class DrawingAreaBase {
> +public:
> +    enum Type {
> +	   None,
> +	   ChunkedUpdateDrawingAreaType,
> +#if USE(ACCELERATED_COMPOSITING)
> +	   LayerBackedDrawingAreaType,
> +#endif
> +    };
> +    
> +    typedef uint64_t DrawingAreaID;
> +    
> +    virtual ~DrawingAreaBase() { }
> +    
> +    Type type() const { return m_type; }
> +    DrawingAreaID id() const { return m_id; }
> +
> +    struct DrawingAreaInfo {
> +	   Type type;
> +	   DrawingAreaID id;
> +
> +	   DrawingAreaInfo(Type type = None, DrawingAreaID indentifier = 0)

Typo, "indentifier."

> +protected:
> +    DrawingAreaBase(Type type, DrawingAreaID indentifier)
> +	   : m_type(type)
> +	   , m_id(indentifier)

Ditto.