[webkit-reviews] review granted: [Bug 41695] [DRT] Assertion failed when drag and move a draggable element. : [Attachment 60629] patch v0

[bugzilla-daemon at webkit.org]

Tony Chang (Google) <tony at chromium.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 41695: [DRT] Assertion failed when drag and move a draggable element.
https://bugs.webkit.org/show_bug.cgi?id=41695

Attachment 60629: patch v0
https://bugs.webkit.org/attachment.cgi?id=60629&action=review

------- Additional Comments from Tony Chang (Google) <tony at chromium.org>
The code looks fine, just some small style nits.

> diff --git a/LayoutTests/fast/events/dragging-mouse-moves.html
b/LayoutTests/fast/events/dragging-mouse-moves.html
> +	   <style> * { margin: 0px; padding: 0px; } </style>
> +	   <script>
> +	  function log(msg)
> +	  {

The code is indented a strange amount here.  Maybe line it up with the <script>
tag?

> +	      if (window.layoutTestController) {
> +		  layoutTestController.waitUntilDone();
> +		  layoutTestController.dumpAsText();
> +		  testDragAndMove();
> +	      }

It would be nice to have a message saying this test requires DRT if
!window.layoutTestController.


> +	      eventSender.mouseMoveTo(startX,startY);
> +	      eventSender.mouseDown();
> +	      // Them drag it. OK not to crash.

Grammar nit: "Then drag it."


> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog

> +	   mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging
started.
> +	   But Cocoa doesn't call mouseDragged() untill dragging is done.

Spelling: until

> +	   Other part of DumpRenderTree also assumes Cocoa behaviour and an
assertion

Spelling/Grammar: behavior (to use the US spelling)

> +	   on UIDelegate failed when mouseDragged() is called dudring dragging.


Spelling: during