[webkit-reviews] review granted: [Bug 43444] PLATFORM(CF) is false on Windows in JavaScriptCore : [Attachment 63378] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 3 14:42:57 PDT 2010


Mark Rowe (bdash) <mrowe at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 43444: PLATFORM(CF) is false on Windows in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=43444

Attachment 63378: Patch
https://bugs.webkit.org/attachment.cgi?id=63378&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
The presence of #define WTF_USE_WININET 1 in Platform.h is very odd, since
WebCore/config.h undefines that macro.	Not really relevant to your patch, but
it’s strange.

Your changes to WebCore/WebCore.xcodeproj/project.pbxproj should be excluded
from this patch since they’re not relevant.

r=me


More information about the webkit-reviews mailing list