[webkit-reviews] review requested: [Bug 43344] Web Inspector: Extensions API tests fail on Qt & GTK : [Attachment 63367] patch

[bugzilla-daemon at webkit.org]

Andrey Kosyakov <caseq at chromium.org> has asked	for review:
Bug 43344: Web Inspector: Extensions API tests fail on Qt & GTK
https://bugs.webkit.org/show_bug.cgi?id=43344

Attachment 63367: patch
https://bugs.webkit.org/attachment.cgi?id=63367&action=review

------- Additional Comments from Andrey Kosyakov <caseq at chromium.org>
The tests broke because platform-specific DumpRenderTree code for Qt & GTK
happened to have developerExtrasEnabled set to false. This was enabled per-page
by the test running code, but not for the inspector page itself.
Performing API injection conditionally on WebInspector::enabled() happened to
be bad idea when enabled() may vary per-page. The only chance to have something
in m_scriptsToEvaluateOnLoad is via WebInspector, so injecting these scripts
when inspector is not enabled() for inspector's page should be ok.