[webkit-reviews] review granted: [Bug 43436] Simple diffs for ~5% complex layout speedup : [Attachment 63357] Proposed changes.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted nholbrook at apple.com's request for
review:
Bug 43436: Simple diffs for ~5% complex layout speedup
https://bugs.webkit.org/show_bug.cgi?id=43436

Attachment 63357: Proposed changes.
https://bugs.webkit.org/attachment.cgi?id=63357&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This looks good.

> -	   RetainPtr<CFMutableDataRef> m_coreTextIndicesData;
> +	   Vector<CFIndex, 64> m_coreTextIndicesVector;

Maybe m_coreTextIndicesStorage would be a better name? Or
m_coreTextIndicesBuffer? The name should communicate the fact that we should
access this through the m_coreTextIndices pointer and not directly.

> +    m_coreTextIndicesVector.reserveCapacity(m_stringLength);

Since this is always used on a new vector, you could use reserveInitialCapacity
for slightly better performance.

r=me without additional changes, but you might want to do one of the
improvements above. If you decide not to do either improvement, please let a
committer know so they can set commit-queue+ on the bug.