[webkit-reviews] review granted: [Bug 42441] <input type=number> UI: Support wheel event : [Attachment 62382] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 3 11:38:55 PDT 2010


Ojan Vafai <ojan at chromium.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 42441: <input type=number> UI: Support wheel event
https://bugs.webkit.org/show_bug.cgi?id=42441

Attachment 62382: Patch 2
https://bugs.webkit.org/attachment.cgi?id=62382&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
> +++ b/LayoutTests/fast/forms/script-tests/input-number-wheel.js
> @@ -0,0 +1,31 @@
> +description('Test for wheel operations for &lt;input type=number>');
> +var parent = document.createElement('div');
> +document.body.appendChild(parent);
> +parent.innerHTML = '<input type=number id=number value=0>';

No need for parent. Can just do the following, no?
document.body.innerHTML = '<input type=number id=number value=0>';

> +var input = document.getElementById('number');
> +input.focus();
> +
> +function dispatchWheelEvent(element, deltaX, deltaY) {

open bracket should be on the following line.

> +    var event = document.createEvent('WheelEvent');
> +    var DontCare = 0;

Should be camelCase (i.e. dontCare).


More information about the webkit-reviews mailing list