[webkit-reviews] review granted: [Bug 43429] [GTK] Does not paint the node highlight used by the inspector : [Attachment 63341] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 3 10:02:37 PDT 2010
Xan Lopez <xan.lopez at gmail.com> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 43429: [GTK] Does not paint the node highlight used by the inspector
https://bugs.webkit.org/show_bug.cgi?id=43429
Attachment 63341: proposed patch
https://bugs.webkit.org/attachment.cgi?id=63341&action=review
------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
>-void InspectorClient::highlight(Node* node)
>+void InspectorClient::highlight(Node*)
> {
>- notImplemented();
>+ hideHighlight();
> }
>
> void InspectorClient::hideHighlight()
> {
>- notImplemented();
>+ // FIXME: we should be able to only invalidate the actual rects of
>+ // the new and old nodes. We need to track the nodes, and take the
>+ // actual highlight size into account when calculating the damage
>+ // rect.
>+ gtk_widget_queue_draw(GTK_WIDGET(m_inspectedWebView));
> }
There's some huge epic fail in naming going on here ;)
>+ ctx.save();
>+ ctx.clip(static_cast<IntRect>(event->area));
>+ frame->page()->inspectorController()->drawNodeHighlight(ctx);
>+ ctx.restore();
> }
As discussed on jabber, the save/restore stuff is probably not needed.
>
> return FALSE;
>--
>1.7.1
>
More information about the webkit-reviews
mailing list