[webkit-reviews] review denied: [Bug 43400] Add priority attribute to XMLHttpRequest : [Attachment 63294] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 3 06:41:42 PDT 2010


Alexey Proskuryakov <ap at webkit.org> has denied James Simonsen
<simonjam+webkit at google.com>'s request for review:
Bug 43400: Add priority attribute to XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=43400

Attachment 63294: Patch
https://bugs.webkit.org/attachment.cgi?id=63294&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This should at least be behind an ifdef, so that platforms that ignore this
flag wouldn't look like they honor it to JS code. Maybe this shouldn't be in
WebKit trunk at all, as it's purely an experiment.

+    const char* const names[5] = { "critical", "high", "normal", "low",
"lowest" };

Normally, constants are numbers, not strings. See e.g.
XMLHttpRequest.readyState.


More information about the webkit-reviews mailing list