[webkit-reviews] review granted: [Bug 43335] Chromium DevTools: Get rid of APUAgent and DebuggerAgent : [Attachment 63248] [PATCH] Now I removed all agents + RPC itself (bot fixed).
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 3 00:31:26 PDT 2010
Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 43335: Chromium DevTools: Get rid of APUAgent and DebuggerAgent
https://bugs.webkit.org/show_bug.cgi?id=43335
Attachment 63248: [PATCH] Now I removed all agents + RPC itself (bot fixed).
https://bugs.webkit.org/attachment.cgi?id=63248&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebCore/inspector/InspectorFrontend.h:156
+ void didGetProfilerLogLines(int position, const String& data);
You should either put calling code behind the same guards or remove the guards
here.Or remove these methods completely.
More information about the webkit-reviews
mailing list