[webkit-reviews] review granted: [Bug 43391] Factor out PendingScript and protect its members : [Attachment 63275] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 2 18:03:16 PDT 2010


Adam Barth <abarth at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 43391: Factor out PendingScript and protect its members
https://bugs.webkit.org/show_bug.cgi?id=43391

Attachment 63275: Patch
https://bugs.webkit.org/attachment.cgi?id=63275&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/dom/PendingScript.h:44
 +  class PendingScript : public CachedResourceClient, Noncopyable {
Noncopyable should probably be the first base class, not that it really
matters.

WebCore/dom/PendingScript.h:69
 +	virtual void notifyFinished(CachedResource*)
Please move to implementation file.  It can't be inlined anyway.


More information about the webkit-reviews mailing list