[webkit-reviews] review denied: [Bug 43390] Do not CRASH if we run out of room for jit code. : [Attachment 63276] The patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 2 16:45:46 PDT 2010
Oliver Hunt <oliver at apple.com> has denied Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 43390: Do not CRASH if we run out of room for jit code.
https://bugs.webkit.org/show_bug.cgi?id=43390
Attachment 63276: The patch
https://bugs.webkit.org/attachment.cgi?id=63276&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
JavaScriptCore/assembler/ARMAssembler.cpp:356
+ for (Jumps::Iterator iter = m_jumps.begin(); iter != m_jumps.end();
++iter) {
if (!data) return 0;
JavaScriptCore/assembler/ARMv7Assembler.h:1631
+ if (copy) {
if (!copy) fail
More information about the webkit-reviews
mailing list