[webkit-reviews] review granted: [Bug 35351] [GTK] DRT implement execCommand() : [Attachment 63136] Patch for this issue

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 35351: [GTK] DRT implement execCommand()
https://bugs.webkit.org/show_bug.cgi?id=35351

Attachment 63136: Patch for this issue
https://bugs.webkit.org/attachment.cgi?id=63136&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
>-bool LayoutTestController::isCommandEnabled(JSStringRef /*name*/)
>+void LayoutTestController::setCacheModel(int)
> {
>     // FIXME: implement
>-    return false;
> }

So in the ChangeLog you say you are only moving this, but you are also adding a
return false. Is it needed or just added by mistake?

> 
>+

Not needed?

> void LayoutTestController::setPersistentUserStyleSheetLocation(JSStringRef
jsURL)
> {
>     // FIXME: implement

Looks good other than that.