[webkit-reviews] review granted: [Bug 41510] Add Base64DecodePolicy option at base64Decode() : [Attachment 63238] Patch (added null-string handling)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 2 11:02:47 PDT 2010
Darin Adler <darin at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 41510: Add Base64DecodePolicy option at base64Decode()
https://bugs.webkit.org/show_bug.cgi?id=41510
Attachment 63238: Patch (added null-string handling)
https://bugs.webkit.org/attachment.cgi?id=63238&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> +bool base64Decode(const String&, Vector<char>&, Base64DecodePolicy policy =
FailOnInvalidCharacter);
> +bool base64Decode(const Vector<char>&, Vector<char>&, Base64DecodePolicy
policy = FailOnInvalidCharacter);
> +bool base64Decode(const char*, unsigned, Vector<char>&, Base64DecodePolicy
policy = FailOnInvalidCharacter);
Normally we would omit the argument name "policy" here.
More information about the webkit-reviews
mailing list