[webkit-reviews] review denied: [Bug 36500] Generated JIT stubs does not compile because of compiler directives : [Attachment 53452] Updated as per Patrick's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 2 07:33:45 PDT 2010


Eric Seidel <eric at webkit.org> has denied David Leong <david.leong at nokia.com>'s
request for review:
Bug 36500: Generated JIT stubs does not compile because of compiler directives
https://bugs.webkit.org/show_bug.cgi?id=36500

Attachment 53452: Updated as per Patrick's comments
https://bugs.webkit.org/attachment.cgi?id=53452&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
No one speaks perl. :)	It's a dead language! :p

Your use of no space around operators is very confusing and against webkit
style.	Please fix.


+    $functiondepth-=()=/[\\}]/g;
especially!?


More information about the webkit-reviews mailing list