[webkit-reviews] review denied: [Bug 42965] CSS: Add fast-path for rgba() color parsing : [Attachment 63183] Proposed patch v3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 2 07:30:52 PDT 2010
Eric Seidel <eric at webkit.org> has denied Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 42965: CSS: Add fast-path for rgba() color parsing
https://bugs.webkit.org/show_bug.cgi?id=42965
Attachment 63183: Proposed patch v3
https://bugs.webkit.org/attachment.cgi?id=63183&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
False alarm or not, it breaks Mac, which is a No-Go.
It's definitely possible to return out of parseAlphaValue without setting
"value" which may be what's confusing the compiler?
Then again the compiler could be right and we could be reading something wrong
here.
More information about the webkit-reviews
mailing list