[webkit-reviews] review canceled: [Bug 43310] Disable speech input layout tests while they get updated. : [Attachment 63166] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 2 07:06:44 PDT 2010


Satish Sampath <satish at chromium.org> has canceled Satish Sampath
<satish at chromium.org>'s request for review:
Bug 43310: Disable speech input layout tests while they get updated.
https://bugs.webkit.org/show_bug.cgi?id=43310

Attachment 63166: Patch
https://bugs.webkit.org/attachment.cgi?id=63166&action=review

------- Additional Comments from Satish Sampath <satish at chromium.org>
> diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
> index
022a19a4a09ebe2ac42c0a38adac91318b345427..3f2ec86ff29cd6ec75ab0b56952972da55acb
a74 100644
> --- a/LayoutTests/ChangeLog
> +++ b/LayoutTests/ChangeLog
> @@ -1,3 +1,12 @@
> +2010-07-31  Satish Sampath  <satish at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Disable speech input layout tests while they get updated.
> +	   https://bugs.webkit.org/show_bug.cgi?id=43310
> +
> +	   * platform/chromium/test_expectations.txt: Disabled speech input
tests.
> +
>  2010-07-31  Andrew Wilson  <atwilson at chromium.org>
>  
>	   Unreviewed un-rollback of r64375 so Satish can land his fixes.
> diff --git a/LayoutTests/platform/chromium/test_expectations.txt
b/LayoutTests/platform/chromium/test_expectations.txt
> index
b642e95b393beef37588b16b9b0cb9b40e4651c5..a237fdf855a0c5ea15b4f3cf9428e10fd46a4
053 100644
> --- a/LayoutTests/platform/chromium/test_expectations.txt
> +++ b/LayoutTests/platform/chromium/test_expectations.txt
> @@ -2883,8 +2883,9 @@ BUGWK41311 WIN LINUX :
fast/borders/borderRadiusDouble07.html = IMAGE
>  BUGWK41311 WIN LINUX : fast/borders/borderRadiusDouble08.html = IMAGE
>  BUGWK41311 WIN LINUX : fast/borders/borderRadiusDouble09.html = IMAGE
>  
> -// Speech input is not yet enabled.
> -BUG44844: fast/speech = IMAGE+TEXT
> +// Speech input UI rendering is partially implemented and not matching the
> +// expected images now, fixing shortly.
> +BUG44844 SKIP: fast/speech = IMAGE+TEXT
>  
>  // v8 bindings for dataset need to be implemented.
>  BUG48133 :  fast/dom/dataset-xhtml.xhtml = TEXT

Committed r64431: <http://trac.webkit.org/changeset/64431>


More information about the webkit-reviews mailing list