[webkit-reviews] review requested: [Bug 43342] AtomicStringHash does not work with null atomic string : [Attachment 63208] Use the pointer to the implementation as the hash value of AtomicString.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 2 06:13:47 PDT 2010
Benjamin Poulain <benjamin.poulain at nokia.com> has asked for review:
Bug 43342: AtomicStringHash does not work with null atomic string
https://bugs.webkit.org/show_bug.cgi?id=43342
Attachment 63208: Use the pointer to the implementation as the hash value of
AtomicString.
https://bugs.webkit.org/attachment.cgi?id=63208&action=review
------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
We know the point is unique by the definition of AtomicString, which makes it a
good candidate for a hash key.
This makes AtomicStringHash works with null key, which is safer in my opinion.
:)
More information about the webkit-reviews
mailing list