[webkit-reviews] review granted: [Bug 43335] Chromium DevTools: Get rid of APUAgent and DebuggerAgent : [Attachment 63205] [PATCH] Proposed change with style addressed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 2 05:56:16 PDT 2010


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 43335: Chromium DevTools: Get rid of APUAgent and DebuggerAgent
https://bugs.webkit.org/show_bug.cgi?id=43335

Attachment 63205: [PATCH] Proposed change with style addressed.
https://bugs.webkit.org/attachment.cgi?id=63205&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebKit/chromium/src/WebDevToolsAgentImpl.cpp:302
 +	if (m_profilerAgentImpl.get() &&
ProfilerAgentDispatch::dispatch(m_profilerAgentImpl.get(), data))
 if (m_profilerAgentImpl.get() &&
ProfilerAgentDispatch::dispatch(m_profilerAgentImpl.get(), data)) should be

 if (m_profilerAgentImpl)
    ProfilerAgentDispatch::dispatch(m_profilerAgentImpl.get(), data);


More information about the webkit-reviews mailing list