[webkit-reviews] review granted: [Bug 43284] [GTK] Create a frame-created signal : [Attachment 63123] Add frame-created signal and test

Mon Aug 2 04:24:21 PDT 2010

Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 43284: [GTK] Create a frame-created signal
https://bugs.webkit.org/show_bug.cgi?id=43284

Attachment 63123: Add frame-created signal and test
https://bugs.webkit.org/attachment.cgi?id=63123&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
>+    g_signal_connect(webView, "frame-created",
G_CALLBACK(createFrameSignalTestFrameCreatedCallback), loop);
>+
>+    // We want to ensure that exactly two create-frame signals are
>+    // fired and no more, so we set a timeout here. There does not appear
>+    // to be a simple way via the API to figure out when all frames have
>+    // loaded.
>+    g_timeout_add(500, createFrameSignalTestTimeout, loop);

webview::document-load-finished does not work?

>+
>+    gtk_container_add(GTK_CONTAINER(window), webView);
>+    gtk_widget_show(window);
>+    gtk_widget_show(webView);
>+
>+    webkit_web_view_load_string(WEBKIT_WEB_VIEW(webView),
>+	  "<html><body>Frames!"
>+	  "<iframe></iframe>"
>+	  "<iframe></iframe>"
>+	  "</body></html>",
>+	  "text/html", "utf-8", "file://");
>+    g_main_loop_run(loop);
>+}
>+

>+    /*
>+     * WebKitWebView::frame-created
>+     * @web_view: the object which received the signal
>+     * @web_frame: the #WebKitWebFrame which was just created.
>+     *
>+     * Emitted when a WebKitWebView has created a new frame. This signal will

>+     * be fired for all sub-frames created during page load. It will not be
>+     * emitted for the main frame, which originates in the WebKitWebView
constructor
>+     * and may be accessed any time using webkit_web_view_get_main_frame.

Missing a Since:

Looks good otherwise.