[webkit-reviews] review granted: [Bug 40002] Need Geolocation LayoutTest to test case where permission has neither been granted nor denied : [Attachment 62699] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 40002: Need Geolocation LayoutTest to test case where permission has
neither been granted nor denied
https://bugs.webkit.org/show_bug.cgi?id=40002

Attachment 62699: Patch
https://bugs.webkit.org/attachment.cgi?id=62699&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+    [[[mainFrame webView] UIDelegate] didSetGeolocationPermission];

I'd still prefer this to be called didSetMockGeolocationPermission (same for a
few other names, of course) . It's hard to understand the various permissions
here, so being specific helps.

+    HashSet<id<WebGeolocationPolicyListener> >
m_pendingGeolocationPermissionListeners;

This code is fine in the short run, but HashSet isn't a great data structure to
keep Objective-C objects in. Specifically, we'll get problems if we try to run
DumpRenderTree in garbage collected mode.  NSMutableSet is the easiest way to
make the code more clean.

r=me, but please consider addressing these comments.