[webkit-reviews] review requested: [Bug 38324] [Qt] Fix compilation with QT_NO_FEATURE : [Attachment 54847] Patch to fix compilation with QT_NO_LINEEDIT

[bugzilla-daemon at webkit.org]

Tasuku Suzuki <tasuku.suzuki at nokia.com> has asked  for review:
Bug 38324: [Qt] Fix compilation with QT_NO_FEATURE
https://bugs.webkit.org/show_bug.cgi?id=38324

Attachment 54847: Patch to fix compilation with QT_NO_LINEEDIT
https://bugs.webkit.org/attachment.cgi?id=54847&action=review

------- Additional Comments from Tasuku Suzuki <tasuku.suzuki at nokia.com>
(In reply to comment #8)
> (From update of attachment 54803 [details])
> WebCore/platform/qt/RenderThemeQt.cpp:278
>  +	  return style->pixelMetric(QStyle::PM_DefaultFrameWidth, &opt, 0);
> I prefer this style as:
> 
> #ifndef NO_LINE_EDIT
>     QtLineEdit lineEdit = 0;
> #else
>    QtLineEdit* lineEdit = m_lineEdit;
> #end
> because then the long call doesn't have to be copied twice.
> 
> Otherwise this looks fine.  Even looks OK as is, I just prefer less
copy/paste
> code.

Done.