[webkit-reviews] review granted: [Bug 38285] REGRESSION: Sandboxing code breaks some javascript: URLs in empty windows : [Attachment 54835] naive fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 30 17:18:02 PDT 2010


Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 38285: REGRESSION: Sandboxing code breaks some javascript: URLs in empty
windows
https://bugs.webkit.org/show_bug.cgi?id=38285

Attachment 54835: naive fix
https://bugs.webkit.org/attachment.cgi?id=54835&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
The reason sandbox flags start with SandboxAll is the principle that it's
safest to start with restrictions and relax them rather than the other way
around. Changing the default setting affects an unknown set of code paths. That
having been said, this change is OK with me. I'd love to hear Adam's take on it
too.


More information about the webkit-reviews mailing list