[webkit-reviews] review requested: [Bug 38213] Page up / page down moves edited content for the entire height : [Attachment 54834] fixed mac link and behavior, other comments addressed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 30 16:33:41 PDT 2010


Zelidrag Hornung <zelidrag at chromium.org> has asked  for review:
Bug 38213: Page up / page down moves edited content for the entire height
https://bugs.webkit.org/show_bug.cgi?id=38213

Attachment 54834: fixed mac link and behavior, other comments addressed  
https://bugs.webkit.org/attachment.cgi?id=54834&action=review

------- Additional Comments from Zelidrag Hornung <zelidrag at chromium.org>
- fixes WebCore::SelectionController::setSelection definition in
WebCore.base.exp
- made cursor align consistent with other apps on Mac
- replaced cursor align control param with enum (instead of bool) in
SelectionController::moveTo/setSelection and related calls
- added better descriptions to ChangeLogs
- compared to previous patch, it has the correct scroll #if logic for Mac vs.
the rest


More information about the webkit-reviews mailing list