[webkit-reviews] review granted: [Bug 38150] Refactoring: webkitEditableContentChangedEvent should be handled by the owner of appropriate the renderer : [Attachment 54663] v1; took feedback

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 30 13:17:12 PDT 2010


Darin Adler <darin at apple.com> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 38150: Refactoring: webkitEditableContentChangedEvent should be handled by
the owner of appropriate the renderer
https://bugs.webkit.org/show_bug.cgi?id=38150

Attachment 54663: v1; took feedback
https://bugs.webkit.org/attachment.cgi?id=54663&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   ASSERT(!shadowAncestor->renderer() ||
shadowAncestor->renderer()->isTextControl());

I'm not sure this assertion is helpful or needed. This code doesn't have any
reason to care about the type of the renderer.

r=me regardless


More information about the webkit-reviews mailing list