[webkit-reviews] review denied: [Bug 38391] makeprop and makevalues: fix build with gcc 4.5 : [Attachment 54812] makeprop and makevalues: fix build with gcc 4.5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 30 11:40:45 PDT 2010


Eric Seidel <eric at webkit.org> has denied Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 38391: makeprop and makevalues: fix build with gcc 4.5
https://bugs.webkit.org/show_bug.cgi?id=38391

Attachment 54812: makeprop and makevalues: fix build with gcc 4.5
https://bugs.webkit.org/attachment.cgi?id=54812&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks like this would break several builds:

../../WebCore/css/CSSPrimitiveValue.h: In constructor
‘WebCore::CSSImageValue::CSSImageValue()’:
../../WebCore/css/CSSPrimitiveValue.h:186: error:
‘WebCore::CSSPrimitiveValue::CSSPrimitiveValue(T) [with T = CSSValueID]’ is
private
../../WebCore/css/CSSImageValue.cpp:40: error: within this context
make: *** [out/Release/obj.target/webcore/../../WebCore/css/CSSImageValue.o]
Error 1
make: *** Waiting for unfinished jobs....


More information about the webkit-reviews mailing list