[webkit-reviews] review granted: [Bug 33875] [Qt] QWebPage::userAgentForUrl is terrible API : [Attachment 54809] Better timing on the userAgentForUrl()

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 33875: [Qt] QWebPage::userAgentForUrl is terrible API
https://bugs.webkit.org/show_bug.cgi?id=33875

Attachment 54809: Better timing on the userAgentForUrl()
https://bugs.webkit.org/attachment.cgi?id=54809&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>

WebKit/qt/Api/qwebpage.cpp:3059
 +	// spliting the string in three and user QStringBuilder is better than
using QString::arg()
splitting

WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1795
 +	const QString markerString = QString::fromLatin1(" nn-NO)");
why two newlines here?