[webkit-reviews] review requested: [Bug 33875] [Qt] QWebPage::userAgentForUrl is terrible API : [Attachment 54809] Better timing on the userAgentForUrl()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 30 09:46:13 PDT 2010


Benjamin Poulain <benjamin.poulain at nokia.com> has asked  for review:
Bug 33875: [Qt] QWebPage::userAgentForUrl is terrible API
https://bugs.webkit.org/show_bug.cgi?id=33875

Attachment 54809: Better timing on the userAgentForUrl()
https://bugs.webkit.org/attachment.cgi?id=54809&action=review

------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
This version avoid some allocations/reallocation of memory, most of the string
being static now.

With this patch, the time of QUrl::setEncodedUrl() is the bottleneck.
Together QUrl::setEncodedUrl() and QWebPage::userAgentForUrl() take 0.02% of
the time.


More information about the webkit-reviews mailing list