[webkit-reviews] review denied: [Bug 38323] Prevents setLastPosition() before startUpdating() being called. : [Attachment 54693] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Marcus Bulach
<bulach at chromium.org>'s request for review:
Bug 38323: Prevents setLastPosition() before startUpdating() being called.
https://bugs.webkit.org/show_bug.cgi?id=38323

Attachment 54693: Patch
https://bugs.webkit.org/attachment.cgi?id=54693&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
> diff --git a/WebKit/chromium/src/WebGeolocationServiceBridgeImpl.cpp
b/WebKit/chromium/src/WebGeolocationServiceBridgeImpl.cpp
> index
07f09da30cd97975622fe13fbd867496a51a9e88..9d755a15d4f7892b81a4e78638e9dbae25c18
1b4 100644
> --- a/WebKit/chromium/src/WebGeolocationServiceBridgeImpl.cpp
> +++ b/WebKit/chromium/src/WebGeolocationServiceBridgeImpl.cpp
> @@ -85,6 +85,7 @@ private:
>      // GeolocationServiceChromium owns us, we only have a pointer back to
it.
>      GeolocationServiceChromium* m_GeolocationServiceChromium;
>      int m_bridgeId;
> +    bool m_startUpdatingRequested;
>  };
>  
>  GeolocationServiceBridge*
createGeolocationServiceBridgeImpl(GeolocationServiceChromium*
geolocationServiceChromium)
> @@ -93,7 +94,8 @@ GeolocationServiceBridge*
createGeolocationServiceBridgeImpl(GeolocationServiceC
>  }
>  
> 
WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl(GeolocationSer
viceChromium* geolocationServiceChromium)
> -    : m_GeolocationServiceChromium(geolocationServiceChromium)
> +    : m_GeolocationServiceChromium(geolocationServiceChromium),

comma on next line