[webkit-reviews] review requested: [Bug 38279] Add CPP bindings generator : [Attachment 54796] Updated patch v2

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 38279: Add CPP bindings generator
https://bugs.webkit.org/show_bug.cgi?id=38279

Attachment 54796: Updated patch v2
https://bugs.webkit.org/attachment.cgi?id=54796&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Fixed most issues Adam raised, except splitting up
GenerateHeader/Implementation in smaller pieces.
I'd love to do that in a follow-up patch, cleaning up the whole
CodeGeneratorCPP.pm module, together with preparing the addition of adding
bindings generation for SVG. Would be great if you'd be fine with that.

While I was at it:
* Implemented a callback mechanism to handle exceptions
(webInstallExceptionHandler)
* Implement WebDOMEventTarget for real. Only thing missing is a way to find out
what's the underlying object (Node/XMLHttpRequest etc..) -> left for a
follow-up patch, because it needs discussion first with other RIM folks
* Fixed all style issues in generated code

nikolaszimmermann ~/Coding/WebKit/WebCore/bindings/cpp > check-webkit-style
*.cpp *.h generated/*.cpp generated/*.h
Total errors found: 0 in 491 files