[webkit-reviews] review granted: [Bug 38249] Vertically shrinking flexbox has wrong height when padding is specified : [Attachment 54547] Proposed Patch 2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 30 01:47:52 PDT 2010
Shinichiro Hamaji <hamaji at chromium.org> has granted Yoshiki Hayashi
<yhayashi at google.com>'s request for review:
Bug 38249: Vertically shrinking flexbox has wrong height when padding is
specified
https://bugs.webkit.org/show_bug.cgi?id=38249
Attachment 54547: Proposed Patch 2
https://bugs.webkit.org/attachment.cgi?id=54547&action=review
------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks good. The original C++ code was apparently wrong and the test case
appropriately checks the code around the fix.
I'd land this manually so I'm setting cq-.
More information about the webkit-reviews
mailing list