[webkit-reviews] review denied: [Bug 38220] [chromium] Add API for querying whether a WebWidget is using GPU accelerated compositing : [Attachment 54458] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Vangelis Kokkevis
<vangelis at chromium.org>'s request for review:
Bug 38220: [chromium] Add API for querying whether a WebWidget is using GPU
accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=38220

Attachment 54458: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=54458&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebPopupMenu.h:44
 +	virtual bool isAcceleratedCompositing() const { return false; }
You should instead implement this method in WebPopupMenuImpl.{h,cpp} just as
you have done in WebViewImpl.{h,cpp}.

WebKit/chromium/public/WebWidget.h:95
 +	virtual bool isAcceleratedCompositing() const = 0;
nit: isAcceleratedCompositingEnabled would be a better (more consistent with
naming conventions) name for this.

WebKit/chromium/src/WebViewImpl.cpp:2041
 +	return m_isAcceleratedCompositing;
ditto.	this variable would be better named m_isAcceleratedCompositingEnabled

WebKit/chromium/src/WebViewImpl.h:363
 +	void setAcceleratedCompositing(bool);
This one should be named enableAcceleratedCompositing to be consistent with
naming conventions.