[webkit-reviews] review granted: [Bug 38363] Handle double on righthand side of a right shift : [Attachment 54760] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 38363: Handle double on righthand side of a right shift
https://bugs.webkit.org/show_bug.cgi?id=38363

Attachment 54760: Patch
https://bugs.webkit.org/attachment.cgi?id=54760&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
I think the if/else cases could be a little clearer if you structured them like
this:

if (isOperandConstantImmediateInt(op2)) {
    // ...
    // ... (1 slow case to link), (optimization goes here!)
    // ...
} else if (isOperandConstantImmediateInt(op1)) {
    // ...
    // ... (1 slow case to link)
    // ...
} else { // !isOperandConstantImmediateInt(op1) &&
!isOperandConstantImmediateInt(op2)
    // ...
    // ... (2 slow cases to link), (optimization goes here!)
    // ...
}

buts that's personal taste, r+ either way.