[webkit-reviews] review denied: [Bug 37981] implement getData('text/html') for webkit win : [Attachment 54123] v2

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 37981: implement getData('text/html') for webkit win
https://bugs.webkit.org/show_bug.cgi?id=37981

Attachment 54123: v2
https://bugs.webkit.org/attachment.cgi?id=54123&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
LayoutTests/ChangeLog:6
 +	    https://bugs.webkit.org/show_bug.cgi?id=37981
Please also mention that 2 layout tests are rebaselined due to the reason you
spoke of.

WebCore/platform/win/ClipboardUtilitiesWin.cpp:394
 +  String getTextHTML(IDataObject* data, bool& success)
It might be better to define the function as:
  bool getTextHTML(IDataObject* data, String& result)

WebCore/platform/win/ClipboardUtilitiesWin.cpp:409
 +  String getCFHTML(IDataObject* data, bool& success)
ditto.

WebCore/platform/win/ClipboardUtilitiesWin.cpp:466
 +	if (SUCCEEDED(data->GetData(htmlFormat(), &store))) {
This and the following line seem to be identical to getCFHTML. Can you change
to call the helper function?

WebCore/platform/win/PasteboardWin.cpp:295
 +		PassRefPtr<DocumentFragment> fragment =
fragmentFromCFHTML(frame->document(), cf_html);
Please also update the name "cf_html".