[webkit-reviews] review denied: [Bug 38334] Allow other ports to compile ATSUI and CoreText functions in SimpleFontData for Mac. : [Attachment 54719] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 29 11:28:46 PDT 2010


mitz at webkit.org has denied Kevin Ollivier <kevino at theolliviers.com>'s request
for review:
Bug 38334: Allow other ports to compile ATSUI and CoreText functions in
SimpleFontData for Mac.
https://bugs.webkit.org/show_bug.cgi?id=38334

Attachment 54719: Patch
https://bugs.webkit.org/attachment.cgi?id=54719&action=review

------- Additional Comments from mitz at webkit.org
This should be done by svn cp’ing SimpleFontDataMac.mm to the two new files and
removing everything but the needed methods, includes and copyright headers. The
#if USE()s should go outside the namespace and the second paragraph of
#includes.


More information about the webkit-reviews mailing list