[webkit-reviews] review denied: [Bug 33287] PNGEncoder.cpp lacks support for libpng 1.4 : [Attachment 54696] libpng.patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Pawel Hajdan jr (ph)
<phajdan.jr at gmail.com>'s request for review:
Bug 33287: PNGEncoder.cpp lacks support for libpng 1.4
https://bugs.webkit.org/show_bug.cgi?id=33287

Attachment 54696: libpng.patch
https://bugs.webkit.org/attachment.cgi?id=54696&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
This change log would be more standard.  Note the moved url.

"""
2010-04-29  Paweł Hajdan, Jr.	<phajdan.jr at chromium.org>

	Reviewed by NOBODY (OOPS!).

	Fix building with libpng-1.4.
	https://bugs.webkit.org/show_bug.cgi?id=33287

	No new tests (no behavior change).

	Original patch by John Bowler <jbowler at acm.org>

	* platform/image-encoders/skia/PNGImageEncoder.cpp:
	(WebCore::PNGImageEncoder::encode):
"""


>      png_struct* pngPtr = png_create_write_struct(PNG_LIBPNG_VER_STRING,
> -						    png_voidp_NULL,
> -						    png_error_ptr_NULL,
> -						    png_error_ptr_NULL);
> +						    0,
> +						    0,
> +						    0);

Put all of these values on one line.