[webkit-reviews] review granted: [Bug 38294] Add fast paths for Math.pow and Math.sqrt : [Attachment 54640] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 38294: Add fast paths for Math.pow and Math.sqrt
https://bugs.webkit.org/show_bug.cgi?id=38294

Attachment 54640: Patch
https://bugs.webkit.org/attachment.cgi?id=54640&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Have you tested USE(JSVALUE32)? – we shouldn't break this.

One thought that might help a little on x86-64, you could plant these
values:...
> +static const double oneConstant = 1.0;
> +static const double negativeHalfConstant = -0.5;
...somewhere in the JIT code buffers, then these could be loaded with a
PC-relative memory access.