[webkit-reviews] review granted: [Bug 38304] [Qt] Reinstate qt_drt_ symbol exports as of QtWebKit 4.6 release : [Attachment 54660] proposed patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 38304: [Qt] Reinstate qt_drt_ symbol exports as of QtWebKit 4.6 release
https://bugs.webkit.org/show_bug.cgi?id=38304

Attachment 54660: proposed patch
https://bugs.webkit.org/attachment.cgi?id=54660&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
> void QWEBKIT_EXPORT qt_drt_run(bool b)

I'm pretty sure this one is not used by anyone outside the DRT, does it really
make sense to reintroduce it?


WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:431
 +  bool QWEBKIT_EXPORT qt_drt_pauseAnimation(QWebFrame *qframe, const QString
&animationName, double time, const QString &elementId)
Wrong coding style, please fix before landing. Also, just use frame, not need
to call it qFrame/qframe.

I think it makes sense to order the DRT methods together and the QWebPage ones
as well; right now they are mixed.