[webkit-reviews] review denied: [Bug 38297] Webkit doesn't compile with 3D-canvas enabled and video disabled : [Attachment 54643] compile fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 28 17:52:15 PDT 2010


Darin Adler <darin at apple.com> has denied Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 38297: Webkit doesn't compile with 3D-canvas enabled and video disabled
https://bugs.webkit.org/show_bug.cgi?id=38297

Attachment 54643: compile fix
https://bugs.webkit.org/attachment.cgi?id=54643&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
>  #include "HTMLVideoElement.h"
>  #include "JSHTMLCanvasElement.h"
>  #include "JSHTMLImageElement.h"
> +#if ENABLE(VIDEO)
>  #include "JSHTMLVideoElement.h"
> +#endif
>  #include "JSImageData.h"
>  #include "JSWebGLBuffer.h"
>  #include "JSWebGLFloatArray.h"

Conditional includes should go in their own paragraph, after the unconditional
ones, not sorted in the include list.

Sorry to be so picky about a minor aspect of the patch.


More information about the webkit-reviews mailing list