[webkit-reviews] review denied: [Bug 38136] [Qt] Add smart paste support : [Attachment 54454] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Robert Hogan
<robert at webkit.org>'s request for review:
Bug 38136: [Qt] Add smart paste support
https://bugs.webkit.org/show_bug.cgi?id=38136

Attachment 54454: Patch
https://bugs.webkit.org/attachment.cgi?id=54454&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

WebCore/editing/qt/SmartReplaceQt.cpp:36
 +  static const QString next = ")].,;:?\'!\"%*-/}";
Hm, what I had in mind is actually a function-local array of char and using
that directly :). The above declaration still ends up allocating a QString
private and converting the read-only constant C string into unicode.

The rest looks good. Sorry, r- because of the heap alloc'ed QString :)

Let me try to rephrase what I wrote in code:

const char next[] = "....";
const char prev[] = "....";

inside the function.