[webkit-reviews] review denied: [Bug 36785] [Qt, Gtk] Allows build-webkit script to accept custom make command as parameter : [Attachment 51971] Patch that adds the --make option.

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Rodrigo Belem
<rclbelem at gmail.com>'s request for review:
Bug 36785: [Qt, Gtk] Allows build-webkit script to accept custom make command
as parameter
https://bugs.webkit.org/show_bug.cgi?id=36785

Attachment 51971: Patch that adds the --make option.
https://bugs.webkit.org/attachment.cgi?id=51971&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
(In reply to comment #6)
> (In reply to comment #5)
> > When building the qtwebkit debian package with the command
> > 
> > dpkg-buildpackage -rfakeroot -j15
> > 
> > and using --makeargs=$(MAKEFLAGS) as following
> > 
> > WebKitTools/Scripts/build-webkit --qt --makeargs=$(MAKEFLAGS)
> > 
> > It does not passes the -j15 correctly to the make command. With the
attached
> > patch and the following command in the debian/rules, it works as desired.
> 
> Why not fix the usage of --makeargs, instead, then? I am assuming it should
> work for your case (in fact, using -j was precisely why it got added in the
> first place).

I agree, fixing the quoting sounds like the better thing to do.