[webkit-reviews] review requested: [Bug 37323] [Qt] tst_QWebHistoryInterface::visitedLinks() fails : [Attachment 54565] fix the svn-apply issue

[bugzilla-daemon at webkit.org]

yi shen <yi.4.shen at nokia.com> has asked  for review:
Bug 37323: [Qt] tst_QWebHistoryInterface::visitedLinks() fails
https://bugs.webkit.org/show_bug.cgi?id=37323

Attachment 54565: fix the svn-apply issue
https://bugs.webkit.org/attachment.cgi?id=54565&action=review

------- Additional Comments from yi shen <yi.4.shen at nokia.com>
Thanks Antonio. Your patch looks nice for me but I am not familiar with
QWebElement::styleProperty() changes. I also updated my patch and attached it
for review. Let Simon decide which patch should be used :)

The reasons why I prefer to add
DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo to handle this test
case are
1) using DRT function for unit testing can also be found in tst_qwebpage.cpp.
2) we may need an implementation of
LayoutTestController::computedStyleIncludingVisitedInfo for Qt, which can
invoke DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo.
see https://bugs.webkit.org/show_bug.cgi?id=37759. I was fighting against the
test script which causes the new interface crashes.