[webkit-reviews] review granted: [Bug 36251] Turn on AUTO_VACUUM for all HTML5 DBs : [Attachment 54482] patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 36251: Turn on AUTO_VACUUM for all HTML5 DBs
https://bugs.webkit.org/show_bug.cgi?id=36251

Attachment 54482: patch
https://bugs.webkit.org/attachment.cgi?id=54482&action=review

------- Additional Comments from David Levin <levin at chromium.org>
This is basically the same patch that dglazkov gave an r+ to, but relanding
after a fix to the chromium test_shell was done, so I'm basically re-adding
dglazkov's r+.



> Index: WebCore/storage/SQLTransaction.cpp
> ===================================================================
> --- WebCore/storage/SQLTransaction.cpp	(revision 58335)
> +++ WebCore/storage/SQLTransaction.cpp	(working copy)
> @@ -466,6 +466,9 @@ void SQLTransaction::postflightAndCommit
>	   return;
>      }
>  
> +    // The commit was successful, vacuum the database if needed

Consider: The commit was successful, so vacuum the database if needed.