[webkit-reviews] review requested: [Bug 37554] REGRESSION: fast/workers/wrapper-map-gc.html crashes on Snow Leopard Release Bot : [Attachment 54484] Patch with a more explicit check.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 27 17:34:06 PDT 2010


Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 37554: REGRESSION: fast/workers/wrapper-map-gc.html crashes on Snow Leopard
Release Bot
https://bugs.webkit.org/show_bug.cgi?id=37554

Attachment 54484: Patch with a more explicit check.
https://bugs.webkit.org/attachment.cgi?id=54484&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
I hope this is better. I've added
ScriptExecutionContext::isJSExecutionTerminated(), which is always 'false' for
Document and becomes 'true' for WorkerContext once Worker.terminate() or
WorkerGlobalScope.clsoe() is invoked.

Apparently, JSC does not crash on reentry while execution is terminated, it
will just cause another exception and almost immediate exit from the JS
fragment.


More information about the webkit-reviews mailing list