[webkit-reviews] review requested: [Bug 38018] new-run-webkit-tests: refactor much of the printing code out of run_webkit_tests.py : [Attachment 54480] try to reduce cut&paste duplication in test methods

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 27 17:14:57 PDT 2010


Dirk Pranke <dpranke at chromium.org> has asked  for review:
Bug 38018: new-run-webkit-tests: refactor much of the printing code out of
run_webkit_tests.py
https://bugs.webkit.org/show_bug.cgi?id=38018

Attachment 54480: try to reduce cut&paste duplication in test methods
https://bugs.webkit.org/attachment.cgi?id=54480&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
Okay, I've attached a patch that only changes printing_unittest.py, in an
attempt to reduce the amount of copied code.

Reducing duplication further gets tricky because the method invocation you're
actually testing has varying arguments, and the output starts to vary. This can
probably be done using an apply() call, but I'm not sure if this is worth it.
Thoughts?


More information about the webkit-reviews mailing list