[webkit-reviews] review granted: [Bug 38225] run-bindings-tests doesn't work in an SVN checkout : [Attachment 54464] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 27 15:54:23 PDT 2010


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 38225: run-bindings-tests doesn't work in an SVN checkout
https://bugs.webkit.org/show_bug.cgi?id=38225

Attachment 54464: Patch
https://bugs.webkit.org/attachment.cgi?id=54464&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
You can probably get the tmp folder from getcwd() or from self._svn_repository
or whatever it's set as.

I think I probably would have fixed SVN's usage instead of the caller of
in_working_directory, since git's seems to take relative paths just fine.

typo:
+	 # I wanted to asser that we got the right path, but there was some


More information about the webkit-reviews mailing list