[webkit-reviews] review granted: [Bug 38207] [V8] Handle OR ('|') conditional in action_derivedsourcesallinone.py : [Attachment 54439] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 27 14:42:01 PDT 2010
Jian Li <jianli at chromium.org> has granted Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 38207: [V8] Handle OR ('|') conditional in action_derivedsourcesallinone.py
https://bugs.webkit.org/show_bug.cgi?id=38207
Attachment 54439: Patch
https://bugs.webkit.org/attachment.cgi?id=54439&action=review
------- Additional Comments from Jian Li <jianli at chromium.org>
r=me
Please land with the following fix.
WebCore/WebCore.gyp/scripts/action_derivedsourcesallinone.py:85
+ # Wraps conditional with ENABLE() and && if more than one conditional is
specified.
Please update the comment.
More information about the webkit-reviews
mailing list