[webkit-reviews] review denied: [Bug 16809] Clicking a scrollbar blurs the currently focused element : [Attachment 54375] patch v1.1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>'s request for review:
Bug 16809: Clicking a scrollbar blurs the currently focused element
https://bugs.webkit.org/show_bug.cgi?id=16809

Attachment 54375: patch v1.1
https://bugs.webkit.org/attachment.cgi?id=54375&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Braces are still wrong in this patch. Not sure what happened there.

A problem with this patch is that it doesn't seem to be making the check at
just the right moment. We've already called updateMouseEventTargetNode, which
presumably is setting the node under the mouse to something wrong, because the
scrollbar is in the way. So I would think we'd want to do the work before
calling updateMouseEventTargetNode.

But if I'm wrong and we correctly set the node under the mouse in
updateMouseEventTargetNode, then I'm noot sure why it's right to
unconditionally return false. After all, we dispatched a mouse event to the
node already. Since in that case we are trying to affect only the focus
behavior then I think the code should go inside the mousedownEvent if
statement.

To be sure this is right, I'd need to confirm that we want to avoid setting the
focused node, but we do want to dispatch the mouse event.